Skip to content

Conversation

@teutoburg
Copy link
Contributor

Cherry-picked from an old branch, but needed for #654.

@teutoburg teutoburg self-assigned this May 15, 2025
@teutoburg teutoburg added the enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label) label May 15, 2025
@teutoburg teutoburg moved this from 🆕 New to 👀 Awaiting Review in ScopeSim-development May 15, 2025
@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.70%. Comparing base (708a08f) to head (dcf9e09).
⚠️ Report is 262 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
+ Coverage   76.69%   76.70%   +0.01%     
==========================================
  Files          70       70              
  Lines        8609     8613       +4     
==========================================
+ Hits         6603     6607       +4     
  Misses       2006     2006              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@teutoburg teutoburg marked this pull request as ready for review May 15, 2025 13:35
@teutoburg teutoburg requested a review from hugobuddel May 15, 2025 13:36
Copy link
Collaborator

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the other day I read (In Siedentop's "Inventing the Individual") that Romulus (according to Plutarchus) dug a ditch when founding Rome, to fill with the earth from their previous city ("terra patria"). But now I am confused, because wasn't Romulus an orphan, so how could he have brought this dirt along?

@teutoburg teutoburg merged commit 50cd716 into main May 19, 2025
39 of 40 checks passed
@teutoburg teutoburg deleted the fh/zerosfromhdr branch May 19, 2025 10:46
@github-project-automation github-project-automation bot moved this from 👀 Awaiting Review to ✅ Done in ScopeSim-development May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PR adding or improving a feature (use "Feature" type for issues (requests), not this label)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants